-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.14.r1] Add appended DTB support #2475
base: aosp/LA.UM.9.14.r1
Are you sure you want to change the base?
[9.14.r1] Add appended DTB support #2475
Conversation
Apparently nobody seems to have tested clang 13 before release, as the whole coding paradigm of calling a function by assigning its return value to a variable, which is used all throughout the Linux kernel, becomes broken, as clang seems utterly drunk when it comes to the actual judgement whether the variable is really used or not..
required configs:
|
ifeq ($(CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE),y) | ||
# Warning! Uncompressed kernel + appended DTB + DTBO WILL NOT WORK! | ||
KBUILD_IMAGE := $(KBUILD_TARGET)-dtb | ||
else | ||
KBUILD_IMAGE := $(KBUILD_TARGET) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original commit has this inside ifeq ($(CONFIG_BUILD_ARM64_KERNEL_COMPRESSION_GZIP),y)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this way it will work with uncompressed kernel without dtbo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dout uncompressed kernel + appended dtb works? Does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was working on 4.19
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(subdir), $(wildcard $(dtstree)/$(d)/*.dts))) | ||
|
||
always := $(dtb-y) | ||
|
||
targets += dtbs | ||
|
||
DTB_NAMES := $(subst $\",,$(CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES)) | ||
ifneq ($(DTB_NAMES),) | ||
DTB_LIST := $(addsuffix .dtb,$(DTB_NAMES)) | ||
else | ||
DTB_LIST := $(dtb-y) | ||
endif | ||
targets += $(DTB_LIST) | ||
|
||
dtbs: $(addprefix $(obj)/, $(DTB_LIST)) | ||
|
||
clean-files := dts/*.dtb *.dtb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved to arch/arm64/boot/Makefile
.
With |
setting as draft in case somebody wants to pick this up for new (old) devices |
Allows a defconfig to set a list of dtbs to concatenate with an Image.gz to create a Image.gz-dtb. Includes 8adb162 arm64: Fix correct dtb clean-files location Change-Id: I0b462322d5c970f1fdf37baffece7ad058099f4a Signed-off-by: Alex Ray <[email protected]> [rishabhb] Use subdir to descend into device tree directories Signed-off-by: Rishabh Bhatnagar <[email protected]> konrad: fast-forward it to msm-5.4
1db68e9
to
3ce8db7
Compare
No description provided.