Conversation
… features from PR#22 Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
…ing logic Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
…dimension handling Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
|
@copilot SoulXPodcastInputParser:- Failed to convert an input value to a INT value: diff_spk_pause_ms, {}, invalid literal for int() with base 10: '{}' |
… handle ComfyUI edge cases Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Fixed in commit 8524822. Added defensive type conversion for |
|
@copilot !!! Exception during processing !!! CacheLayerMixin.init() got an unexpected keyword argument 'max_cache_len' |
This error is not related to the PR changes - it's a compatibility issue between the The issue is that the Solution: Ensure you have pip install transformers==4.57.1This is a pre-existing compatibility issue in the upstream |
|
@copilot you added S1 to S10 audio input, how about output of each speaker with their own sound only |
The original PR#22 for the WebUI included separate audio file outputs for each speaker with ZIP packaging. I didn't implement this feature because ComfyUI has its own audio handling paradigm - nodes output a single audio stream that flows through the workflow. If you need separated speaker audio, you have a few options:
Would you like me to implement option 3 (adding separate audio outputs per speaker)? This would add AUDIO outputs like |
|
@copilot please refer to this pr, for separated speaker audio files, |
…erate node Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Implemented in commit 665dd70. The Outputs:
Each speaker output contains only that speaker's audio segments concatenated together. Speakers not used in the dialogue return Usage example:
This maintains backward compatibility - the first output |
|
@copilot those individual speaker output total length is not same as the combined ones |
…ined audio with temporal alignment Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Fixed in commit 0df37e8. All individual speaker outputs now have the same total length as the combined audio with full temporal alignment. Changes made:
Example: If the combined audio is 30 seconds, speaker_1_audio and speaker_2_audio will also be 30 seconds each - with silence filling the gaps where they're not speaking. This allows you to process speakers separately and recombine them without any sync issues. |
|
@copilot the <|pause:500|> tag not working, the word still get say out loud |
…oken out loud Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Fixed in commit a64cfab. Pause tags like Current behavior:
Note: The inline pause tags currently don't insert actual silence within an utterance - they're simply filtered out. Implementing actual within-utterance pauses would require modifications to the underlying audio generation pipeline in the |
|
@copilot the pause tag not pausing now, |
…sertion Co-authored-by: sooxt98 <13378059+sooxt98@users.noreply.github.com>
Fixed in commit da4b973. Inline pause tags now work correctly by inserting actual silence in the audio. Implementation from PR#22:
Example: Creates 3 segments:
Priority: Inline pause tags take precedence over |
Apply PR#22 Features to ComfyUI Integration - COMPLETE ✅
Successfully applied all features from Soul-AILab/SoulX-Podcast#22 to this ComfyUI integration repository.
All Features Implemented:
<|pause:MS|>with actual silence insertionInline Pause Tags - Fully Implemented
Inline pause tags
<|pause:MS|>now work correctly by inserting actual silence in the audio, matching the implementation from PR#22:How it works:
Example:
This creates 3 separate audio segments:
Priority system:
<|pause:MS|>) take precedence when presentdiff_spk_pause_msapplies between different speakersSeparated Speaker Audio Outputs
The
SoulXPodcastGeneratenode outputs 11 audio streams with temporal alignment:Key features:
Parameter Handling Fix
Fixed issue where
diff_spk_pause_msparameter was receiving unexpected values (like'{}'string) from ComfyUI when optional parameters were not connected. Added defensive type conversion to handle edge cases.Testing Results:
Implementation Status: COMPLETE 🎉
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.