Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): TextArea Value prop이 undefined일 경우 발생하는 타입 에러 수정 #216

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Brokyeom
Copy link
Member

변경사항

  • MaxLength에서 발생하는 string.length가 value 가 undefined(e.g 빈 값일경우) 타입 추론을 하지 못하는 문제에서 발생합니다.
  • 추후에 MaxLength의 경우에 FieldBox의 서브컴포넌트로 분리해 Textarea 자체에서는 MaxLength로 인한 타입 에러가 발생하지 않도록 방지해야 할 것 같습니다.

링크

https://sopt-makers.slack.com/archives/C07AFHC6LDB/p1732615027361309?thread_ts=1731917913.722789&cid=C07AFHC6LDB

시급한 정도

⚠︎ 긴급 : 선 어프루브 후 리뷰를 부탁드립니다. (리뷰는 추후 반영)

기타 사항

Copy link

height bot commented Nov 26, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 18b8d2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sopt-makers/ui Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Brokyeom Brokyeom merged commit 6d311fd into main Nov 26, 2024
2 checks passed
@Brokyeom Brokyeom deleted the fix/ui-textarea-value-length branch November 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant