[Fix] isCoffeeChatActivate param 추가 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jun02160
changed the title
dev-Crayon
reviewed
Nov 9, 2024
| @@ -88,7 +88,7 @@ public record MemberCareerResponse( | |||
| Boolean isCurrent | |||
| ){} | |||
|
|
|||
| public static MemberProfileSpecificResponse checkIsBlindPhone(MemberProfileSpecificResponse response, Boolean isMine) { | |||
| public static MemberProfileSpecificResponse checkIsBlindPhone(MemberProfileSpecificResponse response, Boolean isMine, Boolean isCoffeeChatActivate) { | |||
There was a problem hiding this comment.
메서드 인자로 isMine이랑 isCoffeeChatActivate를 받으니 메서드 명이 해당 로직과 일치하지 않는 것 같네요 더 좋은 메서드 명이 있을까요?
There was a problem hiding this comment.
사실 phone만 마스킹하는 역할이라 해당 함수에서 response 객체를 새로 생성하는 것 자체가 별로이긴 합니다...
요거 개선하려면 Record -> DTO Class로 바꿔서 사용하는 방법이 있을 것 같은데 우선은 38c52d1에서 applyPhoneMasking()으로 변경했어요! 더 좋은 의견 있으시면 부탁드립니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐬 요약
반영이 안 된 부분이 있어 다시 올립니다!
👻 유형
PR의 유형에 맞게 체크해주세요!