Relayer metrics #515
Open
Relayer metrics #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relayer/src/metrics/ethereum.rs
Outdated
Comment on lines
49
to
51
| let beefy = self.beefy.map(|x| BeefyLightClient::new(x, client.inner())); | ||
| let inbound = self.beefy.map(|x| InboundChannel::new(x, client.inner())); | ||
| let outbound = self.beefy.map(|x| OutboundChannel::new(x, client.inner())); |
There was a problem hiding this comment.
Suggested change
| let beefy = self.beefy.map(|x| BeefyLightClient::new(x, client.inner())); | |
| let inbound = self.beefy.map(|x| InboundChannel::new(x, client.inner())); | |
| let outbound = self.beefy.map(|x| OutboundChannel::new(x, client.inner())); | |
| let beefy = self.beefy.map(|x| BeefyLightClient::new(x, client.inner())); | |
| let inbound = self.inbound.map(|x| InboundChannel::new(x, client.inner())); | |
| let outbound = self.outbound.map(|x| OutboundChannel::new(x, client.inner())); |
Typo?
relayer/src/cli/mod.rs
Outdated
| if self.enable_metrics { | ||
| let mut builder = metrics_exporter_prometheus::PrometheusBuilder::new(); | ||
| if let Some(address) = &self.prometheus_address { | ||
| builder = builder.with_http_listener(address.clone()); |
There was a problem hiding this comment.
Suggested change
| builder = builder.with_http_listener(address.clone()); | |
| builder = builder.with_http_listener(*address); |
relayer/src/metrics/ethereum.rs
Outdated
| metrics::absolute_counter!(ETH_OUTBOUND_NONCE, nonce, labels); | ||
| } | ||
| let block_number = self.client.get_block_number().await?.as_u64(); | ||
| metrics::counter!(ETH_BLOCK_NUMBER, block_number, labels); |
There was a problem hiding this comment.
Suggested change
| metrics::counter!(ETH_BLOCK_NUMBER, block_number, labels); | |
| metrics::absolute_counter!(ETH_BLOCK_NUMBER, block_number, labels); |
Set an absolute value, not increment.
relayer/src/metrics/para.rs
Outdated
| vset.id, | ||
| labels | ||
| ); | ||
| metrics::absolute_counter!( |
There was a problem hiding this comment.
Counter is a monotonic value, but as I understand, the next length might be less than current. Consider gauge type for the metric.
relayer/src/metrics/para.rs
Outdated
| .beefy_light_client() | ||
| .current_validator_set(network_id); | ||
| self.update_metric(&address, block_hash, |vset| { | ||
| metrics::absolute_counter!( |
There was a problem hiding this comment.
Id the ID is not a monotonic, consider gauge type.
relayer/src/metrics/sora.rs
Outdated
Comment on lines
88
to
89
| metrics::absolute_counter!(SUB_BEEFY_CURRENT_ID, vset.id); | ||
| metrics::absolute_counter!(SUB_BEEFY_CURRENT_LEN, vset.len as u64); |
There was a problem hiding this comment.
If ID and length is not a monotonic, consider gauge.
relayer/src/metrics/ethereum.rs
Outdated
| metrics::absolute_counter!(ETH_BEEFY_LATEST_BLOCK, latest_block, labels); | ||
| } | ||
| if let Some(contract) = &self.inbound { | ||
| let nonce: u64 = contract.nonce().call().await?; |
There was a problem hiding this comment.
Suggested change
| let nonce: u64 = contract.nonce().call().await?; | |
| let nonce: u64 = contract.batch_nonce().call().await?; |
It is batch_nonce in develop in InboundChannel.sol
# Conflicts: # Cargo.lock # relayer/src/cli/bridge/relay/sora/evm.rs # relayer/src/substrate/mod.rs
|
@vovac12 can we merge and close this ? |
Patch relayer metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.