Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple CI pipeline via GitHub actions #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

david-a-wheeler
Copy link

Create a simple CI pipeline via GitHub actions.
This does a basic "cargo test" on several different environments
and two different versions of Rust. Eventually more checks can
be added.

Signed-off-by: David A. Wheeler [email protected]

Create a simple CI pipeline via GitHub actions.
This does a basic "cargo test" on several different environments
and two different versions of Rust. Eventually more checks can
be added.

Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
Deduplication doesn't work well with a matrix, so for now
just do things twice.

For now let's not test on nightly, but just ensure that things
work on the Rust stable branch.

Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
Increase the likelihood of the software working on many
platforms by testing on more platform versions.

Signed-off-by: David A. Wheeler <[email protected]>
@sorear
Copy link
Owner

sorear commented Nov 28, 2020

I didn't ask for any of this.

@david-a-wheeler
Copy link
Author

I'm not sure I understand your comment. It's normal to always test all changes in a variety of environments, to ensure that the proposed change works.

@david-a-wheeler
Copy link
Author

My apologies if my proposals are annoying; that isn't my intent.

I think it's important to establish an automated CI pipeline and to eliminate all warnings (including lint warnings) over time. Rust has changed over the years; I intend to change the code so it is idiomatic to current Rust usage. I also intend to propose a large number of changes over time to make this capable of doing more (including a C interface & definition checking). I also want to merge Mario's proposed change to support all Metamath proof formats.

I'd rather work with you to make all these changes. But if that's not the direction you want to go, you have every right to say no to all of it. If that isn't the direction you want to go, I'll probably just create & maintain a separate fork of the project, ensuring that everything is done in many public commits so you can cherry-pick what you like if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants