Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Grab data from grafana snap #3410

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

arif-ali
Copy link
Member

@arif-ali arif-ali commented Nov 9, 2023

Closes: #3278


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3410
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just the one note below.

sos/report/plugins/grafana.py Outdated Show resolved Hide resolved
Closes: sosreport#3278

Co-authored-by: Pravesh Gaire <[email protected]>
Signed-off-by: Pravesh Gaire <[email protected]>
Signed-off-by: Arif Ali <[email protected]>
Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is a reason for collecting just one config file under snap pkg manager vs. whole directory in other cases, so ACK.

@TurboTurtle TurboTurtle merged commit 8779206 into sosreport:main Nov 26, 2023
30 checks passed
@arif-ali arif-ali deleted the sos-arif-grafana-snap branch October 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grafana] Collect data for snap installation
3 participants