Add support for RHOSP 18 Openstack EDPM deployment #3414
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
rebtoor
force-pushed
the
osp18
branch
2 times, most recently
from
2a0c3f3 to
6dfe375
Compare
rebtoor
force-pushed
the
osp18
branch
3 times, most recently
from
a01dc92 to
350d2ed
Compare
sos/report/plugins/openstack_nova.py
Outdated
| "admin_password", "connection_password", | ||
| "memcache_secret_key", "s3_secret_key", | ||
| "metadata_proxy_shared_secret", "fixed_key", "transport_url", | ||
| "rbd_secret_uuid", |
There was a problem hiding this comment.
you could add the rbd_secret_uuid above instead. As it's a regex, it should just work
sos/report/plugins/libvirt.py
Outdated
| class RedHatLibvirt(Libvirt, RedHatPlugin): | ||
|
|
||
| def setup(self): | ||
| super(RedHatLibvirt, self).setup() | ||
| self.add_copy_spec([ | ||
| "/var/lib/openstack/config/libvirt", | ||
| "/var/lib/openstack/containers/libvirt*.json", | ||
| ]) | ||
|
|
||
| if not self.get_option("all_logs"): | ||
| self.add_copy_spec([ | ||
| "/var/log/containers/qemu/*.log", | ||
| "/var/log/containers/libvirt/*.log", | ||
| ]) | ||
| else: | ||
| self.add_copy_spec([ | ||
| "/var/log/containers/qemu/", | ||
| "/var/log/containers/libvirt/", | ||
| ]) |
There was a problem hiding this comment.
I don't think we need to split this out.
The /var/lib/openstack paths should, arguably, be collected by one of the openstack plugins. However, assuming we keep the collection in the libvirt plugin, we can simply add these to the existing collection lists. If they don't exist on a particular system, we skip them gracefully.
Further, the /var/log/containers paths fit nicely in with what is already called in the existing IndependentPlugin structure.
There was a problem hiding this comment.
I thought it was redundant to create an openstack_libvirt plugin since i would basically be copying most of this one, but i agree that we can avoid to split the logic. Let me fix it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@rebtoor this looks fine now, but it needs a rebase on current |
Ack! I'll do it ASAP. Thanks a lot! |
EDPM (External DataPlane Management) will be the new way to deploy compute nodes startin from RHOSP 18 which will replace TripleO/Director - Added openstack_edpm plugin - Added custom path for config and logs in frr/libvirt/logrotate/openstack_neutron/openstack_nova/ovn_host modules - Tagged libvirt/openstack_neutron/openstack_nova/ovn_host modules as `openstack_edpm` Signed-off-by: Roberto Alfieri <[email protected]>
|
/packit rebuild-failed |
|
@TurboTurtle is there something I can do to unlock packit builds? |
|
/packit rebuild-failed |
|
Account arif-ali has no write access nor is author of PR! |
|
/packit rebuild-failed |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
LGTM, thanks @rebtoor |
openstack_edpm is added in sosreport/sos#3414
|
@TurboTurtle is there an existing policy to get new tags/releases and builds? I'm wondering if we have a timeline to get this patch into a package (mostly commenting for CentOS). |
A new sos upstream version (typically 4.Y) is released every 6 months, see https://github.com/sosreport/sos/releases . Beyond that, tags (like 4.5.6) were created every 4 weeks to allow such frequent release policy from Red Hat. We / from Red Hat have paused this in past few months due to several independent reasons, but plan to start tagging upstream the same way soon. |
|
JIRA OSPRH-5744 |
EDPM (External DataPlane Management) will be the new way to deploy compute nodes startin from RHOSP 18 which will replace TripleO/Director.
openstack_edpmpluginopenstack_edpm_computePlease place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines