Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lustre] Collect most params #3424

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

utopiabound
Copy link
Contributor

Collect almost all params, except those explicitly excluded.
Those excluded are known to be less useful debugging, and/or known to be very large.

Some params are still split out to help limit size.

Some very large (but possibly useful) param are relegated to --all-logs


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3424
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

sos/report/plugins/lustre.py Outdated Show resolved Hide resolved
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I restarted the CI jobs.

@utopiabound utopiabound requested a review from jcastill November 30, 2023 16:11
Collect almost all params, except those explicitly excluded.
Those excluded are known to be less useful debugging, and/or
known to be very large.

Some params are still split out to help limit size.

Some very large (but possibly useful) param are relegated to `--all-logs`

Signed-off-by: Nathaniel Clark <[email protected]>
@TurboTurtle TurboTurtle merged commit 70a00c4 into sosreport:main Dec 26, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants