Skip to content

Fix two minor issues in man page#3983

Merged
TurboTurtle merged 1 commit into
sosreport:mainfrom
maximiliankolb:fix_link
May 27, 2025
Merged

Fix two minor issues in man page#3983
TurboTurtle merged 1 commit into
sosreport:mainfrom
maximiliankolb:fix_link

Conversation

@maximiliankolb

@maximiliankolb maximiliankolb commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@maximiliankolb
Fix URL to upstream project
fdc090d 
With the whitespace, you end up at the wrong GitHub page when clicking
on the link in the man page.

Tested on EL 9.5:
$ rpm -q sos
sos-4.8.2-2.el9_5.noarch

Signed-off-by: Maximilian Kolb <kolb@atix.de>
@packit-as-a-service

packit-as-a-service Bot commented Apr 4, 2025

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3983
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

arif-ali
arif-ali reviewed Apr 4, 2025
View reviewed changes
Comment thread man/en/sos.1 Outdated
@arif-ali arif-ali added Status/Need More Info Feedback is required to reproduce issue or to continue work Status/Needs Review This issue still needs a review from project members Kind/Documentation Updates and Fixes documentation labels Apr 8, 2025
@pmoravec pmoravec added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer and removed Status/Need More Info Feedback is required to reproduce issue or to continue work Status/Needs Review This issue still needs a review from project members labels May 25, 2025
@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer labels May 27, 2025
@TurboTurtle TurboTurtle merged commit 8a4cac3 into sosreport:main May 27, 2025
38 checks passed
@maximiliankolb maximiliankolb deleted the fix_link branch May 28, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arif-ali arif-ali arif-ali left review comments
@TurboTurtle TurboTurtle TurboTurtle approved these changes
@pmoravec pmoravec pmoravec approved these changes

Assignees

No one assigned

Labels

Kind/Documentation Updates and Fixes documentation Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maximiliankolb @arif-ali @TurboTurtle @pmoravec