[apache] Update apache/httpd plugin for RHEL10#3990
Merged
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
reviewed
Apr 16, 2025
| self.add_copy_spec(f"{ldir}/{log}") | ||
|
|
||
| self.add_copy_spec([ | ||
| "/var/lib/httpd/*" |
Member
There was a problem hiding this comment.
minor nit, add comma at the end, if there are new changes afterwards, it would be a one-line change rather than 2
arif-ali
requested changes
Apr 16, 2025
arif-ali
left a comment
arif-ali
left a comment
Member
There was a problem hiding this comment.
Just a few minor points, otherwise all good
| ]) | ||
|
|
||
| self.add_forbidden_path([ | ||
| "/var/lib/httpd/*.pem" |
| r"\1 ********,") | ||
| self.do_path_regex_sub('/var/lib/httpd/.*json', | ||
| r"(\"e\"\s*:|\"n\"\s*:)(.*[^,]$)", | ||
| r"\1 ********") |
Member
There was a problem hiding this comment.
they style we prefer is below, could we amend the above 2 to go in line please.
self.do_path_regex_sub(
'/var/lib/httpd/.*json',
r"(\"e\"\s*:|\"n\"\s*:)(.*[^,]$)",
r"\1 ********"
)
arif-ali
added
Status/Need More Info
dwolstroRH
force-pushed
the
update-apache-plugin
branch
from
c23b1c5 to
6048fa8
Compare
TurboTurtle
reviewed
Apr 21, 2025
TurboTurtle
left a comment
TurboTurtle
left a comment
Member
There was a problem hiding this comment.
Linting comment below, otherwise looks good overall.
Comment on lines
+160
to
+167
| '/var/lib/httpd/.*json', | ||
| r"(\"e\"\s*:|\"n\"\s*:)(.*[,]$)", | ||
| r"\1 ********," | ||
| ) | ||
| self.do_path_regex_sub( | ||
| '/var/lib/httpd/.*json', | ||
| r"(\"e\"\s*:|\"n\"\s*:)(.*[^,]$)", | ||
| r"\1 ********" |
Member
There was a problem hiding this comment.
CI is failing due to indentation level. Each of these lines should be nested one level inside the method call, e.g.
self.do_path_regex_sub(
'/var/lib/httpd/.*json',
r"(\"e\"\s*:|\"n\"\s*:)(.*[,]$)",
r"\1 ********,"
)
Member
|
@dwolstroRH any updates on this one, some minor issues and this would be good. |
Related: SUPDEV-168 Signed-off-by: David Wolstromer <dwolstro@redhat.com>
dwolstroRH
force-pushed
the
update-apache-plugin
branch
from
6048fa8 to
81fb90b
Compare
pmoravec
approved these changes
Jun 1, 2025
pmoravec
added
Reviewed/Needs 2nd Ack
TurboTurtle
approved these changes
Jun 1, 2025
TurboTurtle
added
Reviewed/Ready for Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: SUPDEV-168
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines