[cleaner] Use "hostname -f" in HostnamePrepper#4026
Merged
TurboTurtle merged 1 commit intoMay 27, 2025
Merged
Conversation
HostnamePrepper should always be fed by FQDN to ensure domain names are recognized properly. This is important esp. when: - /etc/hosts is empty - "hostname" contains shortname only - "hostname -f" contains FQDN Resolves: sosreport#4022 Closes: sosreport#4026 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
TurboTurtle
approved these changes
May 27, 2025
jjansky1
pushed a commit
to jjansky1/sos
that referenced
this pull request
Jun 19, 2025
HostnamePrepper should always be fed by FQDN to ensure domain names are recognized properly. This is important esp. when: - /etc/hosts is empty - "hostname" contains shortname only - "hostname -f" contains FQDN Resolves: sosreport#4022 Closes: sosreport#4026 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostnamePrepper should always be fed by FQDN to ensure domain names are recognized properly.
This is important esp. when:
Resolves: #4022
Closes: #4026
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines