Skip to content

[cleaner] Use "hostname -f" in HostnamePrepper#4026

Merged
TurboTurtle merged 1 commit into
sosreport:mainfrom
pmoravec:sos-pmoravec-cleaner-prepper-hostname-full
May 27, 2025
Merged

[cleaner] Use "hostname -f" in HostnamePrepper#4026
TurboTurtle merged 1 commit into
sosreport:mainfrom
pmoravec:sos-pmoravec-cleaner-prepper-hostname-full

Conversation

@pmoravec

Copy link
Copy Markdown
Contributor

HostnamePrepper should always be fed by FQDN to ensure domain names are recognized properly.

This is important esp. when:

  • /etc/hosts is empty
  • "hostname" contains shortname only
  • "hostname -f" contains FQDN

Resolves: #4022
Closes: #4026


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

HostnamePrepper should always be fed by FQDN to ensure domain names are
recognized properly.

This is important esp. when:
- /etc/hosts is empty
- "hostname" contains shortname only
- "hostname -f" contains FQDN

Resolves: sosreport#4022
Closes: sosreport#4026

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4026
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge Kind/cleaner cleaner component of sos labels May 27, 2025
@TurboTurtle TurboTurtle merged commit 1d44904 into sosreport:main May 27, 2025
39 checks passed
jjansky1 pushed a commit to jjansky1/sos that referenced this pull request Jun 19, 2025
HostnamePrepper should always be fed by FQDN to ensure domain names are
recognized properly.

This is important esp. when:
- /etc/hosts is empty
- "hostname" contains shortname only
- "hostname -f" contains FQDN

Resolves: sosreport#4022
Closes: sosreport#4026

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/cleaner cleaner component of sos Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleaner does not obfuscate domain name in image mode

2 participants