Skip to content

[archive] Print stderr if the gpg command fails#4032

Merged
arif-ali merged 1 commit into
sosreport:mainfrom
jcastill:jcastillo-add-stderr-gpg
May 30, 2025
Merged

[archive] Print stderr if the gpg command fails#4032
arif-ali merged 1 commit into
sosreport:mainfrom
jcastill:jcastillo-add-stderr-gpg

Conversation

@jcastill

Copy link
Copy Markdown
Member

Since stderr is now captured in sos_get_command_output() this commit enables it for the _encrypt() function and prints the error received if the gpg command failed.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Since stderr is now captured in sos_get_command_output()
this commit enables it for the _encrypt() function and
prints the error received if the gpg command failed.

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4032
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jcastill jcastill requested a review from pmoravec May 29, 2025 10:45

@pmoravec pmoravec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not. While I think the gpg feature is almost never used (at least I havent seen it to be used, at least).

@arif-ali arif-ali merged commit fc08b8b into sosreport:main May 30, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants