Skip to content

[sunbeam_hypervisor] Add services#4040

Merged
TurboTurtle merged 1 commit into
sosreport:mainfrom
arif-ali:sos-arif-sunbeam-hypervisor-services
Jun 9, 2025
Merged

[sunbeam_hypervisor] Add services#4040
TurboTurtle merged 1 commit into
sosreport:mainfrom
arif-ali:sos-arif-sunbeam-hypervisor-services

Conversation

@arif-ali

@arif-ali arif-ali commented Jun 4, 2025

Copy link
Copy Markdown
Member

The services tuple does not like regex, so adding them individually

Closes: #4039


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@arif-ali arif-ali added Kind/Ubuntu Ubuntu related item Status/Needs Review This issue still needs a review from project members Kind/Collection New or updated command or file collection labels Jun 4, 2025
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4040
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

* The services tuple does not like regex, so adding them individually
* Sometimes the journalctl cane take time to collect the logs, adding
  plugin_timeout to 600

Closes: sosreport#4039
Signed-off-by: Arif Ali <arif.ali@canonical.com>
@arif-ali arif-ali force-pushed the sos-arif-sunbeam-hypervisor-services branch from 01f0c63 to c4973b0 Compare June 4, 2025 16:01

@gboutry gboutry left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thats the case, isn't it better to sudo snap logs -n all openstack-hypervisor?

I don't think maintaining a list of units is very pertinent in the context of a snap, what do you think @arif-ali ?

Comment thread sos/report/plugins/sunbeam_hypervisor.py
@arif-ali

arif-ali commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

If thats the case, isn't it better to sudo snap logs -n all openstack-hypervisor?

I don't think maintaining a list of units is very pertinent in the context of a snap, what do you think @arif-ali ?

makes sense, will update it in the next PR update

@arif-ali

arif-ali commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

If thats the case, isn't it better to sudo snap logs -n all openstack-hypervisor?

I don't think maintaining a list of units is very pertinent in the context of a snap, what do you think @arif-ali ?

After some testing this morning in my lab env, it seems that running sudo snap logs -n all openstack-hypervisor can take a long time to run, and aggregates loads of logs. This means with the timeouts we have, not all logs would be collected. It makes sense to split these to ensure that we get all the logs.

We do this similarly in all the plugins we have in sos, so keeping this as is makes sense.

@TurboTurtle TurboTurtle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Status/Needs Review This issue still needs a review from project members labels Jun 9, 2025
@TurboTurtle TurboTurtle merged commit d9c1cc0 into sosreport:main Jun 9, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/Collection New or updated command or file collection Kind/Ubuntu Ubuntu related item Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sunbeam_hypervisor] systemd journal logs does not provide logs

4 participants