Skip to content

[saltmaster] Obfuscate pillar roots in any path#4059

Merged
TurboTurtle merged 4 commits into
sosreport:mainfrom
TrevorBenson:sos-tbenson-saltmaster-obfuscation
Jun 21, 2025
Merged

[saltmaster] Obfuscate pillar roots in any path#4059
TurboTurtle merged 4 commits into
sosreport:mainfrom
TrevorBenson:sos-tbenson-saltmaster-obfuscation

Conversation

@TrevorBenson

Copy link
Copy Markdown
Member
  • Obfuscates root level passwords, secrets and keys
  • Includes api and encryption keys, but keeps original negative lookbehind for any other "key"
  • Obfuscates a pillar root in any collected path in addition to /etc/salt

Closes #4058


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4059
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Signed-off-by: Trevor Benson <trevor.benson@gmail.com>
…kbehind.

Signed-off-by: Trevor Benson <trevor.benson@gmail.com>
Signed-off-by: Trevor Benson <trevor.benson@gmail.com>
@TrevorBenson TrevorBenson force-pushed the sos-tbenson-saltmaster-obfuscation branch from 906830a to 472c221 Compare June 18, 2025 19:24
Comment thread sos/report/plugins/saltmaster.py
Signed-off-by: Trevor Benson <trevor.benson@gmail.com>
@TrevorBenson TrevorBenson force-pushed the sos-tbenson-saltmaster-obfuscation branch from 01026c6 to f852ace Compare June 19, 2025 17:33
@TrevorBenson TrevorBenson requested a review from TurboTurtle June 19, 2025 17:37
@TurboTurtle TurboTurtle added Kind/Enhancement Reviewed/Ready for Merge Has been reviewed, ready for merge Kind/Obfuscation Fixes an Obfuscation issue labels Jun 21, 2025
@TurboTurtle TurboTurtle merged commit 40ffbf6 into sosreport:main Jun 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/Enhancement Kind/Obfuscation Fixes an Obfuscation issue Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[saltmaster] can fail to obfuscate during postproc

3 participants