[tftpserver] Merge pxe plugin into tftpserver#4060
Merged
Conversation
Member
Author
|
Kept it as an |
TurboTurtle
added
Kind/Enhancement
Status/Needs Review
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
pmoravec
approved these changes
Jun 19, 2025
Contributor
|
Leaving on @arif-ali / @TrevorBenson for an ACK from Debian/Ubuntu side. |
arif-ali
requested changes
Jun 19, 2025
| plugin_name = 'tftpserver' | ||
| profiles = ('sysmgmt', 'network') | ||
|
|
||
| services = ('tftp', ) |
Member
There was a problem hiding this comment.
Please add tftpd-hpa service here
| def setup(self): | ||
| self.add_dir_listing([ | ||
| '/var/lib/tftpboot', | ||
| self.add_copy_spec('/etc/defaultd/tftp-hpa') |
Member
There was a problem hiding this comment.
typo, that should be /etc/default/tftp-hpa
bmr-cymru
approved these changes
Jun 19, 2025
The `pxe` plugin was both antiquated in that no currently supported distribution ships the `pxeos` command, and also duplicating some behavior best served by the `tftpserver` plugin. Move the relevant bits from `pxe` to `tftpserver`, then drop the `pxe` plugin. Add some additional collections to `tftpserver` such as service status collections. Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
arif-ali
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pxeplugin was both antiquated in that no currently supported distribution ships thepxeoscommand, and also duplicating some behavior best served by thetftpserverplugin.Move the relevant bits from
pxetotftpserver, then drop thepxeplugin. Add some additional collections totftpserversuch as service status collections.Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines