Skip to content

spec: Use new RPM macros on RHEL 11+ as well#4072

Merged
TurboTurtle merged 1 commit into
sosreport:mainfrom
hroncok:patch-1
Jul 8, 2025
Merged

spec: Use new RPM macros on RHEL 11+ as well#4072
TurboTurtle merged 1 commit into
sosreport:mainfrom
hroncok:patch-1

Conversation

@hroncok

@hroncok hroncok commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

See https://fedoraproject.org/wiki/Changes/DeprecateSetuppyMacros

This ensures that in ELN, the new macros are used.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code? N/A
  • Does the commit contain a Signed-off-by: First Lastname email@example.com? No
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated? Not applicable.

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4072
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali

arif-ali commented Jul 8, 2025

Copy link
Copy Markdown
Member

Can you sign your commit please

git commit -s --amend

Then force push to your banch

@arif-ali arif-ali added Status/Needs Review This issue still needs a review from project members Kind/RedHat RedHat related item labels Jul 8, 2025
@hroncok

hroncok commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

I have created this patch by using the GitHub web interface. Amending the commit message is not trivial. Sigh.

See https://fedoraproject.org/wiki/Changes/DeprecateSetuppyMacros

This ensures that in ELN, the new macros are used.

Signed-off-by: Miro Hrončok <miro@hroncok.cz>
@hroncok

hroncok commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Done.

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Status/Needs Review This issue still needs a review from project members labels Jul 8, 2025
@TurboTurtle TurboTurtle merged commit 034d0d3 into sosreport:main Jul 8, 2025
38 checks passed
@hroncok hroncok deleted the patch-1 branch July 22, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/RedHat RedHat related item Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants