[openshift_ovn] Allow specific container runtime for plugin command

[dwolstroRH]

This Update allows a specific container runtime to be passed to add_cmd_output so commands that must use a specific runtime do so.

Related: SUPDEV-180

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-4076
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[TurboTurtle]

Does this collection not behave correctly when directly specifying the glob? Is that why we're also changing this to a per-file iteration?

[dwolstroRH]

When this command was getting executed, the filename '/var/run/ovn/ovn-controller..ctl' parameter within the command string was not getting expanded. The '' represents the current process id of the container, ie, '/var/run/ovn/ovn-controller.3127.ctl', which lead to a "File Not Found Error" condition when executing the command. I changed to find the filename before passing the command string into add_cmd_output.

[TurboTurtle]

a_c_o() takes a list or a string. With this change now doing single files at a time the list is superfluous.

Also, please convert these to f-strings. A while back we made an effort to convert everything we could to f-strings, but I guess we overlooked this.

[dwolstroRH]

These are separate calls because they target different containers and the container parameter is not part of the list. These calls previously existed, I simply updated them to pass the file name correctly. I will update the 3 calls that I changed to use f-strings.

Accidentally hit approve on this instead of comment.

[TurboTurtle]

LGTM. If you could please rebase to current main, we'll get this merged.