[kdump|release] Change format of imports#4078
Merged
TurboTurtle merged 1 commit intoJul 10, 2025
Merged
Conversation
Change the format of the import line for plugins to parenthesis so it matches what we do in all other plugins that contain multiline imports. Also, this change ensures that the script plugins_overview.py's output is consistent across all plugins and doesn't contain errors. Related: sosreport#4071 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
approved these changes
Jul 10, 2025
arif-ali
left a comment
Member
There was a problem hiding this comment.
lgtm, makes it consistent across all the plugins
TurboTurtle
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the format of the import line for plugins
to parenthesis so it matches what we do in all
other plugins that contain multiline imports.
Also, this change ensures that the script
plugins_overview.py's output is consistent
across all plugins and doesn't contain
errors.
Related: #4071
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines