Accepts a custom matplotlib.colors.Normalize object#42
Open
vaidyasm wants to merge 1 commit intososuneko:masterfrom
Open
Accepts a custom matplotlib.colors.Normalize object#42vaidyasm wants to merge 1 commit intososuneko:masterfrom
vaidyasm wants to merge 1 commit intososuneko:masterfrom
Conversation
…m' key in 'plot_params' dict passed as argument to 'pdpbox.pdp.pdp_interact_plot()' method.
Author
|
@SauceCat Error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR,
pdpbox.pdp.pdp_interact_plot()makes use of user specified (if any)matplotlib.colors.Normalizeobject as value for'norm'key in'plot_params'dictionary argument. A user initialized normalize object can be used & reused to obtain consistent normalization of 'marginal effect' being plotted. If this key is not set, the method is set to behave as unmodified version by passingNoneas norm to_pdp_inter_one().This PR was created to address #39
Affect of this PR can be seen in following two plots.
The 'Before' plots uses full color scale regardless of the range of 'marginal effect' being plotted.
In the 'After' plots, color mappings are consistent with values of the 'marginal effect' being plotted.
Interaction plots with large variations in marginal effects can now be identified with cursory look at 'After' plots, without having to read off range from color scale.
Plot 1: Small Range of Marginal Effect
Before:

After:

Plot 2: Large Range of Marginal Effect
Before:

After:
