Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vision input for generation utils. #119

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Jun 19, 2024

This PR supports vision/image input for generation utils, which would allow interaction to be grounded in vision inputs. This PR relies on #116

📑 Description

Uses Langchain's ImagePromptTemplate to add image url to chat messages.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

@ProKil ProKil added this to the 0.2.0 Release milestone Jun 19, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.96%. Comparing base (8d9b9be) to head (f8e59c0).

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   60.03%   59.96%   -0.07%     
==========================================
  Files          47       47              
  Lines        2402     2413      +11     
==========================================
+ Hits         1442     1447       +5     
- Misses        960      966       +6     
Files Coverage Δ
tests/generation_utils/test_generation.py 68.42% <ø> (ø)
sotopia/generation_utils/generate.py 51.53% <41.66%> (-0.27%) ⬇️

@ProKil ProKil marked this pull request as ready for review September 9, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant