Use IsoCodes test data for validators #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
iso-codes-tests
branch
2 times, most recently
from
7875589
to
ba7fb56
Compare
soullivaneuh
changed the title
soullivaneuh
force-pushed
the
iso-codes-tests
branch
from
ba7fb56
to
c7cabf9
Compare
greg0ire
reviewed
Jan 10, 2017
| */ | ||
| private function getIsoCodesTestInstance() | ||
| { | ||
| // Test classes seems not be autoloaded by default. |
There was a problem hiding this comment.
In composer.json, you can specify how to generate autoload mechanisms for whatever you want (including those test classes I think). Using autoload-dev will ensure you don't clutter your production autoload mechanism.
soullivaneuh
force-pushed
the
iso-codes-tests
branch
2 times, most recently
from
eeecd1c
to
c5ec93d
Compare
This will reduce a lot the test code length and make new integrations easier.
soullivaneuh
force-pushed
the
iso-codes-tests
branch
from
c5ec93d
to
ccd0342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting ronanguilloux/IsoCodes#92 to be finished.
composer.jsonhackIPorIsbn...Update "How to add a constraint documentation" doc accordingly.Documentation does not exist yet.If ronanguilloux/IsoCodes#93 is merged before new stable release of IsoCodes, remove special case from
CreditCardValidatorTest::getValidValues.