fix default salt for create (#300)

soundxyz · Dec 21, 2023 · 4dce1f4 · 4dce1f4
1 parent 6f7f687
commit 4dce1f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/chilled-pants-compete.md b/.changeset/chilled-pants-compete.md
@@ -0,0 +1,6 @@
+---
+'@soundxyz/legacy-sdk': minor
+'@soundxyz/sdk': minor
+---
+
+Fix default salt for create
diff --git a/packages/legacy-sdk/src/client/edition/create.ts b/packages/legacy-sdk/src/client/edition/create.ts
@@ -50,7 +50,7 @@ async function createEditionHelper(
     maxPriorityFeePerGas,
   }
 
-  const formattedSalt = keccak256(toHex(customSalt || Math.random() * 1_000_000_000_000_000))
+  const formattedSalt = keccak256(toHex(customSalt || Math.floor(Math.random() * 1_000_000_000_000_000)))
 
   // Precompute the edition address.
   const [editionAddress, _] = await retry(
@@ -355,7 +355,7 @@ export async function expectedEditionAddress(
   { deployer, salt: customSalt }: { deployer: Address; salt: string | number },
 ) {
   const { readContract } = await this.expectClient()
-  const formattedSalt = keccak256(toHex(customSalt || Math.random() * 1_000_000_000_000_000))
+  const formattedSalt = keccak256(toHex(customSalt))
 
   const [editionAddress, exists] = await readContract({
     abi: soundCreatorV1Abi,

diff --git a/packages/sdk/src/contract/edition-v2/read/create.ts b/packages/sdk/src/contract/edition-v2/read/create.ts
@@ -320,7 +320,7 @@ export async function getExpectedEditionAddress<Client extends Pick<PublicClient
   client: Client,
   { deployer, salt: customSalt }: GetExpectedEditionAddressParams,
 ): Promise<GetExpectedEditionAddressReturnType> {
-  const formattedSalt = keccak256(toHex(customSalt || Math.random() * 1_000_000_000_000_000))
+  const formattedSalt = keccak256(toHex(customSalt || Math.floor(Math.random() * 1_000_000_000_000_000)))
 
   const [edition, exists] = await client.readContract({
     abi: SOUND_CREATOR_V2_ABI,