Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat ui: remove user avatars, remove speaker name from follow-up message #6981

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Feb 6, 2025

The user knows who they are, why show it next to every message? It clutters the UI. So I removed the avatar from the human messages (we still have the avatar in the top right).

I also removed the name from the follow-up message. It doesn't add anything.

Ideally we'd remove the "user name" every where but when I did that, the layout looked kinda bad because there was still the 'split into chat' button.

Before

before

After

after

Test plan

  • N/A

The user knows who they are, why show it next to every message? It
clutters the UI. So I removed the avatar from the human messages (we
still have the avatar in the top right).

I also removed the name from the follow-up message. It doesn't add
anything.

Ideally we'd remove the "user name" every where but when I did that, the
layout looked kinda bad because there was still the 'split into chat'
button.
@mrnugget mrnugget requested a review from a team February 6, 2025 20:28
@mrnugget mrnugget merged commit 127d52c into main Feb 6, 2025
21 checks passed
@mrnugget mrnugget deleted the mrn/declutter-messages branch February 6, 2025 21:12
@kalanchan
Copy link
Contributor

kalanchan commented Feb 6, 2025

@mrnugget should the LLM avatar also be removed too? now it looks off centered from the left. I personally don't mind the avatar being there, it keeps all the icons consistent on the left. But if we're going to remove it maybe just remove the name entirely

CleanShot 2025-02-06 at 14 16 19@2x

@mrnugget
Copy link
Contributor Author

mrnugget commented Feb 6, 2025

But if we're going to remove it maybe just remove the name entirely

You mean the user name? Or the model name?

@kalanchan
Copy link
Contributor

But if we're going to remove it maybe just remove the name entirely

You mean the user name? Or the model name?

the username. I think we should either do all avatar, no names, or only names no avatars.

I think it feels inconsistent now, theres a name (no avatar), SG icon, LLM icon + name in a single turn of the chat

sqs pushed a commit that referenced this pull request Feb 7, 2025
…age (#6981)

The user knows who they are, why show it next to every message? It
clutters the UI. So I removed the avatar from the human messages (we
still have the avatar in the top right).

I also removed the name from the follow-up message. It doesn't add
anything.

Ideally we'd remove the "user name" every where but when I did that, the
layout looked kinda bad because there was still the 'split into chat'
button.

## Before

![before](https://github.com/user-attachments/assets/2ce844e1-275a-42e4-876c-5d18bb011a47)

## After

![after](https://github.com/user-attachments/assets/364a23a7-242b-4ed7-a49f-08de8df6b47f)

## Test plan

- N/A
julialeex pushed a commit that referenced this pull request Feb 7, 2025
… follow-up message (#7009)

The user knows who they are, why show it next to every message? It
clutters the UI. So I removed the avatar from the human messages (we
still have the avatar in the top right).

I also removed the name from the follow-up message. It doesn't add
anything.

Ideally we'd remove the "user name" every where but when I
did that, the layout looked kinda bad because there was still the
'split into chat' button.

## Before

![before](https://github.com/user-attachments/assets/2ce844e1-275a-42e4-876c-5d18bb011a47)

## After

![after](https://github.com/user-attachments/assets/364a23a7-242b-4ed7-a49f-08de8df6b47f)

## Test plan

- N/A <br> Backport 127d52c from #6981

Co-authored-by: Thorsten Ball <[email protected]>
kalanchan added a commit that referenced this pull request Feb 26, 2025
This PR improves VS Code release notes generation by introducing
changelog summarization. The new `release-notes.ts` script creates easy
to understand, categorized release notes with emojis and clear
formatting. This refactoring also makes it more simple to plugin future
changelogs.

The following output is an example of what will be used in the release
script.

Example output for `v1.70.1`:
```
✨ For the full technical changelog, see [What’s new in v1.70.0](https://github.com/sourcegraph/cody/blob/main/vscode/CHANGELOG.md) since v1.68.0 ✨

This release brings significant improvements to the chat interface, enhanced auto-edit functionality, and various bug fixes to improve the overall user experience.

✨ New Features
- Support for dynamic mentions in prompt templates, making @ mentions more flexible and context-aware [#6793](#6793)
- Enhanced image handling in auto-edit with better alignment and user-specific font size support [#7036](#7036)

🔄 Improvements
- Streamlined chat interface with simplified UI and improved user experience [#6992](#6992)
- Enhanced prompt caching for code context messages, improving response times [#6953](#6953)
- Improved code border styles for better visual clarity [#7024](#7024)

🐛 Bug Fixes
- Fixed 500ms delay when submitting chat messages [#6991](#6991)
- Resolved issues with @ mention menu appearing outside the editor window [#7045](#7045)
- Fixed low resolution images on low DPI screens [#7112](#7112)
- Corrected language filters in rules not applying properly [#7025](#7025)

🎨 UI Enhancements
- Improved repository filter dropdown functionality [#6994](#6994)
- Enhanced history search interface with fixed border styling [#6983](#6983)
- Simplified chat UI by removing user avatars and streamlining message presentation [#6981](#6981)


**Full Comparison**: M68...M70
```


Example output for `v1.70.1`:
```
✨ For the full technical changelog, see [What’s new in v1.70.1](https://github.com/sourcegraph/cody/blob/main/vscode/CHANGELOG.md) since v1.70.0 ✨

This minor update addresses a specific issue with Cody's agentic chat functionality.

🐛 Bug Fixes
- Fixed an issue where terminal and openCtx tools were not properly registered in agentic chat, ensuring better functionality and tool availability [#7132](#7132)


**Full Comparison**: M68...M70
```

## Test plan
tested locally using `npx ts-node ./scripts/release-notes.ts`

<!-- Required. See
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->
hitesh-1997 pushed a commit that referenced this pull request Feb 26, 2025
This PR improves VS Code release notes generation by introducing
changelog summarization. The new `release-notes.ts` script creates easy
to understand, categorized release notes with emojis and clear
formatting. This refactoring also makes it more simple to plugin future
changelogs.

The following output is an example of what will be used in the release
script.

Example output for `v1.70.1`:
```
✨ For the full technical changelog, see [What’s new in v1.70.0](https://github.com/sourcegraph/cody/blob/main/vscode/CHANGELOG.md) since v1.68.0 ✨

This release brings significant improvements to the chat interface, enhanced auto-edit functionality, and various bug fixes to improve the overall user experience.

✨ New Features
- Support for dynamic mentions in prompt templates, making @ mentions more flexible and context-aware [#6793](#6793)
- Enhanced image handling in auto-edit with better alignment and user-specific font size support [#7036](#7036)

🔄 Improvements
- Streamlined chat interface with simplified UI and improved user experience [#6992](#6992)
- Enhanced prompt caching for code context messages, improving response times [#6953](#6953)
- Improved code border styles for better visual clarity [#7024](#7024)

🐛 Bug Fixes
- Fixed 500ms delay when submitting chat messages [#6991](#6991)
- Resolved issues with @ mention menu appearing outside the editor window [#7045](#7045)
- Fixed low resolution images on low DPI screens [#7112](#7112)
- Corrected language filters in rules not applying properly [#7025](#7025)

🎨 UI Enhancements
- Improved repository filter dropdown functionality [#6994](#6994)
- Enhanced history search interface with fixed border styling [#6983](#6983)
- Simplified chat UI by removing user avatars and streamlining message presentation [#6981](#6981)


**Full Comparison**: M68...M70
```


Example output for `v1.70.1`:
```
✨ For the full technical changelog, see [What’s new in v1.70.1](https://github.com/sourcegraph/cody/blob/main/vscode/CHANGELOG.md) since v1.70.0 ✨

This minor update addresses a specific issue with Cody&#39;s agentic chat functionality.

🐛 Bug Fixes
- Fixed an issue where terminal and openCtx tools were not properly registered in agentic chat, ensuring better functionality and tool availability [#7132](#7132)


**Full Comparison**: M68...M70
```

## Test plan
tested locally using `npx ts-node ./scripts/release-notes.ts`


 <br> Backport 2e3b785 from #7150

Co-authored-by: Kalan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants