change receivers to share_ptr

[sicxs]

change receivers to share_ptr

[auscaster]

Hi @sicxs just wondering the reason for using shared_ptr here? The Ref.alive boolean should always be set when the ref is dereferenced

[auscaster]

I opted for the lightweight pointer approach here since the socket adapter is a single threaded event loop listener

[sicxs]

When the server runs, everything is normal.
When the server is closed, if the removeReceiver is not called, it will lead to a memory leak.
But when the server is off, I also need to listen to the onSocketClose event, do the memory release, and not call the removeReceiver
This creates a contradiction. If shared_ptr is used, I don't need to call removeReceiver when the server is closed

[auscaster]

Would an alternate solution here be to call remove all listeners internally inside server close method? I'm aiming for optimal performance and would like to resolve this without bringing in shared ptr if possible.

…

On 28 November 2017 at 02:12, sicxs ***@***.***> wrote: When the server runs, everything is normal. When the server is closed, if the removeReceiver is not called, it will lead to a memory leak. But when the server is off, I also need to listen to the onSocketClose event, do the memory release, and not call the removeReceiver This creates a contradiction. If shared_ptr is used, I don't need to call removeReceiver when the server is closed — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#203 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGKDBdmdobtwzaB7RUF8kCsIGcaodUqks5s613wgaJpZM4QrRZg> .

[sicxs]

Please solve the problem of memory leakage
When the server is closed, make sure that there is no memory leak

[seawolf0820]

I fixed it in this way and no memory leak:

diff --git a/src/net/src/socketadapter.cpp b/src/net/src/socketadapter.cpp
index 2fdea5e2..1ad1ece0 100644
--- a/src/net/src/socketadapter.cpp
+++ b/src/net/src/socketadapter.cpp
@@ -32,6 +32,7 @@ SocketAdapter::SocketAdapter(SocketAdapter* sender)
 
 SocketAdapter::~SocketAdapter()
 {
+    for_each(_receivers.begin(), _receivers.end(), [=] (Ref* ref) { delete ref; });
     // LTrace("Destroy")
     // assert(_receivers.empty());
 }