Update pyproject.toml #2672
Closed
Update pyproject.toml #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ctb
added a commit
that referenced
this pull request
Oct 15, 2023
This PR rationalizes `sig plot` arguments for `--labels` (show names) and `--indices` (show numbers), and adds `--no-labels` and `--no-indices`, as follows. See #2667 for motivating bug. 1. `sourmash plot compare-demo` - labels on dendrogram, labels on matrix ✅ (FIXED) 2. `sourmash plot compare-demo --labels` - labels on both dendrogram and matrix ✅ 3. `sourmash plot compare-demo --indices` - indices on both dendrogram and matrix ✅ 4. `sourmash plot compare-demo --labels --indices` - labels on both ✅ (FIXED - labels override indices) New arguments from this PR: 5. `sourmash plot compare-demo --no-labels` - indices on both ✅ 6. `sourmash plot compare-demo --no-labels --no-indices` - no labels/indices on either ✅ 7. `sourmash plot compare-demo --no-indices` - labels on both ✅ The PR also simplifies some of the `plot` command code as well as code in `fig.py`. TODO: - [x] write some tests for new args - [x] update documentation - [x] check to see if notebook code should be updated Fixes #2667 Closes #2672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a simple check for the
--labelscommand for the dendrogram plot without heat map. This wasn't previously implemented which resulted in an asymmetric handling of labels for the dendrogram and dendrogram+heatmap plot for the sourmash plot command.Fixes #2667