Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resumability for revindex #3275

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Implement resumability for revindex #3275

merged 4 commits into from
Aug 19, 2024

Conversation

luizirber
Copy link
Member

Allow recovering from a failed create/update by reprocessing signatures that were not marked complete/processed.

Will probably to a version bump in DB (0 -> 1), with V0 assuming all datasets were processed properly, and V1 being able to track which datasets from the manifest failed or where not processed yet.

(From a discussion with @MGS-sails)

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.67%. Comparing base (8c9dfce) to head (2a3a14f).
Report is 2 commits behind head on latest.

Files Patch % Lines
src/core/src/index/revindex/disk_revindex.rs 80.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3275      +/-   ##
==========================================
+ Coverage   86.66%   86.67%   +0.01%     
==========================================
  Files         137      137              
  Lines       15962    15998      +36     
  Branches     2728     2728              
==========================================
+ Hits        13834    13867      +33     
- Misses       1819     1822       +3     
  Partials      309      309              
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.37% <ø> (ø)
rust 62.86% <80.48%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luizirber luizirber marked this pull request as ready for review August 6, 2024 04:21
@luizirber
Copy link
Member Author

luizirber commented Aug 7, 2024

@sourmash-bio/devs not sure how to test this one

  • we don't have a previous version of the DB as test data, to check if the assumptions hold when updating it (that all sigs in the DB were processed properly)
  • how to crash the process in the middle of processing, restart, and make sure it returns same results as if it went all the way to the end?

I did this with https://github.com/sourmash-bio/branchwater and it worked as expected.

Otherwise, ready for review!

@luizirber luizirber merged commit c621bd5 into latest Aug 19, 2024
43 of 44 checks passed
@luizirber luizirber deleted the lirber/bw_resume branch August 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant