Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hp, dayhoff options to manysketch #345

Merged
merged 11 commits into from
Sep 29, 2024
Merged

Add hp, dayhoff options to manysketch #345

merged 11 commits into from
Sep 29, 2024

Conversation

olgabot
Copy link
Contributor

@olgabot olgabot commented Jun 2, 2024

Fixes #337 to add support for dayhoff and hp moltypes to manysketch.

To create sketches using the new functionality from protein sequences only (no translation from DNA sequences, sorry), the dayhoff, hp, moltypes can be specified in the parameter string:

sourmash scripts manysketch proteins.csv -o proteins.zip -p dayhoff,k=16 -p protein,k=10 -p hp,k=42

Where proteins.csv looks like:

name,genome_filename,protein_filename
protein1,,protein1.fa
protein2,,protein2.fa

@olgabot olgabot marked this pull request as draft June 2, 2024 18:54
bluegenes and others added 2 commits June 15, 2024 11:41
)

* add changes from directsketch

* ahh, needed dna in default param str

* add err msg and tests for error i just encountered
@olgabot olgabot marked this pull request as ready for review June 21, 2024 15:40
@olgabot olgabot requested review from bluegenes and ctb June 23, 2024 03:55
Copy link
Collaborator

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @olgabot this looks great to me!

I note that it doesn't look like the manysketch docs need any changes. We still don't do translation, but that's ok ;)

I would like to ask you to change the PR title and description -

  • right now it talks about multisketch not manysketch
  • the PR description should be updated to close How to do manysketch on dayhoff, hp moltypes? #337 when this is merged (i.e. Fixes #337) and also should include a brief description of the new functionality.

If you'd like to add yourself to the authorship list in the README and pyproject.toml that would also be fine! No push either way - this may be too small a PR - but if you want to, please do!

@olgabot olgabot changed the title Add hp, dayhoff options to multisketch Add hp, dayhoff options to manysketch Jun 24, 2024
@olgabot
Copy link
Contributor Author

olgabot commented Jul 3, 2024

I note that it doesn't look like the manysketch docs need any changes. We still don't do translation, but that's ok ;)

Added a section about protein sketching with manysketch!

the PR description should be updated to close #337 when this is merged (i.e. Fixes #337) and also should include a brief description of the new functionality.

Added! Let me know if more elaboration is needed.

If you'd like to add yourself to the authorship list in the README and pyproject.toml that would also be fine! No push either way - this may be too small a PR - but if you want to, please do

By the time I finish #354, I'll probably have forgotten to add myself, so I'm doing it now.

@olgabot olgabot requested a review from ctb July 3, 2024 15:36
doc/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! One suggestion for you to consider on documentation, but otherwise - go ahead and merge! (You should be able to merge now - if not, lmk.)

@ctb
Copy link
Collaborator

ctb commented Jul 12, 2024

hi @olgabot is it ok if I update with my suggestion and then merge? I'm hoping to do a new release in the next day or two.

Co-authored-by: C. Titus Brown <[email protected]>
@olgabot
Copy link
Contributor Author

olgabot commented Sep 28, 2024

hi @olgabot is it ok if I update with my suggestion and then merge? I'm hoping to do a new release in the next day or two.

Yes, totally fine to merge!

@olgabot olgabot enabled auto-merge (squash) September 28, 2024 19:17
@olgabot olgabot merged commit 13ce36e into main Sep 29, 2024
2 checks passed
@olgabot olgabot deleted the olgabot/hp-dayhoff branch September 29, 2024 13:10
@ctb ctb mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to do manysketch on dayhoff, hp moltypes?
3 participants