Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimation for the expires time for transferring large files #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbbco
Copy link

@bbbco bbbco commented Mar 6, 2017

Description

Sometimes the download I am trying will timeout while finishing to download because it is a very large file (multiple GBs). This change allows you to define a timeout with the expires attribute; otherwise it employs some basic math to determine how long to set the timeout.

Issues Resolved

[List any existing issues this PR resolves]

Check List

@josephholsten
Copy link

@bbbco did you want us to be able to merge this? It seems reasonable, but we can't unless you legally permit us to by using a DCO Signed-off-by.

@bbbco bbbco changed the title Add estimation for the expires time for transferring large files Add estimation for the expires time for transferring large files Aug 30, 2018
@bbbco bbbco changed the title Add estimation for the expires time for transferring large files Add estimation for the expires time for transferring large files | Signed-off-by: Brian Goad <[email protected]> Aug 30, 2018
@bbbco bbbco changed the title Add estimation for the expires time for transferring large files | Signed-off-by: Brian Goad <[email protected]> Add estimation for the expires time for transferring large files Aug 30, 2018
@bbbco bbbco force-pushed the s3_estimate_time branch from 0d0d10d to 620100a Compare August 30, 2018 04:03
@bbbco
Copy link
Author

bbbco commented Aug 30, 2018

@josephholsten signed

@bbbco
Copy link
Author

bbbco commented Sep 29, 2023

lolz at all the approvals of this five year old PR. @xorima you might want to check on whatever bot you have automating PRs these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants