Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ubuntu 24.04 #718

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

tomkrouper
Copy link

Description

  • Add support for Ubuntu 24.04 (noble numbat)

Issues Resolved

List any existing issues this PR resolves

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@tomkrouper tomkrouper requested a review from a team as a code owner December 3, 2024 18:48
@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 57a2ebd to 2a28bf2 Compare December 3, 2024 23:06
@tomkrouper
Copy link
Author

Looking at the ubuntu-2404, smoke80 failure, I wonder if the 8.035 deprecation that says `%` no longer includes `localhost` is to blame. I'll dig further tomorrow.

@tomkrouper
Copy link
Author

Looking at the ubuntu-2404, smoke80 failure, I wonder if the 8.035 deprecation that says % no longer includes localhost is to blame. I'll dig further tomorrow.

From local testing with the mysql client, this doesn't appear to be the problem. I'm running to arm64 vs x86_64 issues with running kitchen locally.

The non-ubuntu smoke tests seem to be a different issue entirely.

@damacus
Copy link
Member

damacus commented Dec 9, 2024

Ping me on here or Slack when you get to the bottom of the Ubuntu 22.04 smoke error. I'm not worried about the other suites given you haven't changed them.

@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 47d8396 to 10aacb8 Compare December 9, 2024 17:07
@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 10aacb8 to 2d4f237 Compare December 9, 2024 17:38
@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 2afd4d1 to 48957ad Compare December 9, 2024 17:54
@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 48957ad to ee271f2 Compare December 9, 2024 17:55
@tomkrouper
Copy link
Author

It appears that port is not being honored by the mysql_service library.

When you look at the above line, the port is set to 3306 but in

mysql_service 'slave-1' do
port '3307'
the port is set to 3307. I can not find any changes that would have broken this behavior so far.

@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label Dec 10, 2024
@tomkrouper tomkrouper force-pushed the feat/add-support-ubuntu-24-04 branch from 713ce0b to 06799bb Compare December 11, 2024 04:18
@tomkrouper
Copy link
Author

I think I'm running into this:

The port issue may not be an issue. What I pointed out previously seems to continue at the top of the next hour then goes on to password issues seen later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants