Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new resource: network_interfaces_eni #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add new resource: network_interfaces_eni #32

wants to merge 1 commit into from

Conversation

jeffbyrnes
Copy link
Contributor

Uses the aws-sdk gem, added as a dependency to metadata

This is some older work that @eherot did, I’ve rebased it & stacked it up here for perusal by all.

@jeffbyrnes jeffbyrnes self-assigned this Mar 14, 2018
@jeffbyrnes jeffbyrnes force-pushed the add-network_interfaces_eni branch from 75ce557 to 9665281 Compare November 28, 2020 20:58
@eherot @jeffbyrnes
feat: Add new resource: network_interfaces_eni
79d2acd 
Uses the aws-sdk gem, added as a dependency to metadata
@jeffbyrnes jeffbyrnes force-pushed the add-network_interfaces_eni branch from 9665281 to 79d2acd Compare November 28, 2020 21:02
@jeffbyrnes jeffbyrnes added Feature Request Enhancement to existing functionality or new functionality Priority: Low Is a nice to have, not an essential Release: Minor Release to Chef Supermarket as a minor release when merged labels Nov 28, 2020
bmhughes
bmhughes reviewed Jun 29, 2021
View reviewed changes
Copy link

@bmhughes bmhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small recommendation, other than that looks good!

resources/eni.rb
end
end

private
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these can be added to the action_class block rather than adding them to the 'outer' resource class.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.chef.io/custom_resources/#action_class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmhughes! I did a big refactor in #44, so once that merges, and I rebase #43 & get it merged, I’ll come back to this one.

@bmhughes
Copy link

Oh and it wants a rebase on main too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmhughes bmhughes bmhughes left review comments

@xorima xorima xorima approved these changes

Assignees

@jeffbyrnes jeffbyrnes

Labels
Feature Request Enhancement to existing functionality or new functionality Priority: Low Is a nice to have, not an essential Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffbyrnes @bmhughes @xorima @xorimabot @eherot