-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decimal separator and thousands separator #22
base: master
Are you sure you want to change the base?
Conversation
I understand that this is a controversial PR, because adapting to the different conventions for writing numbers can be done in many different ways. |
Thinking about my previous comment, I found the first big problem with this PR (and with the handling of the thousands separator in general): |
OK, I fixed that by parsing words without |
I noticed only now that |
Other ideas: |
I decided to go with the 5 separator modes (with the “dumb” |
One last idea: |
No description provided.