Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit configurations for the repository #192

Open
franklinselva opened this issue Sep 26, 2024 · 0 comments
Open

Add pre-commit configurations for the repository #192

franklinselva opened this issue Sep 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@franklinselva
Copy link

Feature description

Currently, we have considerably a large number of files being altered and moved within the repository. I am recommending the addition of pre-commit configurations to setup all the contributions to the same standard we would like to have in the project.

Implementation considerations

The pre-commit configurations could possibly validate the following:

  • Dockerfile linting
  • Shell formatting and linting
  • Missing trailing whitespaces
  • Markdown linting
  • End of file Fixer
  • Check for large files
  • Check Merge conflicts
  • Check yaml
  • Check xml

The list is based on the current status of the repository. This could also potentially allow us to extend the CI for pre-commit validation as a part of the workflow.

@franklinselva franklinselva added the enhancement New feature or request label Sep 26, 2024
franklinselva added a commit to franklinselva/spaceros-stacks that referenced this issue Sep 26, 2024
Related to space-ros#192

Add precommit configs for
 - file testing
 - docker linting
 - shell linting and formatting
 - python linting and formatting
 - cpp linting and formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant