Draft: Augment audio system with the ability to have captions #5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontaoski
changed the title
This is important groundwork for future features such as captioning, as a caption and other data can be associated with the collection prototype instead of passing extra data everywhere with the sound.
pontaoski
force-pushed
the
work/jblackquill/caption
branch
from
975a9d9 to
e710d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on top of #5540, look at the changes of the latest commit only (or look at pontaoski#1)
Mainly manages
CaptionComponents attached to the audio entities whenever they should display a visible caption. Can't use aCaptionfield on theAudioComponentdue to theComponentTreeSystemwanting to listen to theComponentStartup/ComponentShutdownevents that are already being listened to by the clientAudioSystem.