Try fix entity deserialization component composition #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes complex inheritance pushing when deserializing entities. This is meant to try and fix a bug where deserialization of entities with components/data-fields with the AlwaysPushInheritance would insert unwanted prototype data into loaded entities.
E.g., this was causing the action grant component to gain an ever growing number of actions in the content test map anytime it was loaded & saved.
This also tries to prevent some possible issues where inheritance pushing wasn't cloning some fields, which might've lead to accidentally modifying a parent's data.