fix some issues with ClientDisconnect #5625
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue with ClientDisconnect (and by extension the DisconnectCommand)
turns out that DisconnectCommand is sort of a fucky-wucky
the issue was that we weren't properly handling disconnects during active connection attempts - the code assumed you were already connected when trying to disconnect (2017 code my beloved)
now you can actually disconnect while connecting without breaking the universe 👍