Remove unused obsolete TryGetContainingContainer override #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtisticRoomba
added
the
Status: Requires Content PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of existing calls to this method that are compatible with the
Entity<T>version which still throwObsoletewarnings because they use anEntityUidand apparently the conversion to anEntity<T>is lower priority.As a result this fixes ~a dozen obsolete warnings.
Requires space-wizards/space-station-14#34912
Breaking Changes
Any downstreams still using the obsolete version and passing the components separately will need to pack them with the uid now.
Otherwise, if they were relying on the implicit conversion from a different
Entity<T>or similar they'll need to use.OwnerIf they were just passing an
EntityUidthey should be fine.