A compilation of simple one-line fixes #5661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces call to TransformComponent.GetMapUid with SharedTransformSystem.GetMap
Fixes a couple calls to obsolete varients of SetAwake and an obsolete call to RegenerateContacts by converting them to their Entity<T> varients
Adds one set of parenthesis to convert a 'uid, comp, comp, comp' call to an 'Entity<T, T, T> call.
Removes an unused list of broadphases that was being allocated in TryCollideRect
Fixes all of the easy warnings regarding physics island processing, the rest require more complicated changes than a simple argument rearrangement
TemporalOroboros
commented
Feb 6, 2025
Slightly more complicated than the rest, but it's really just changing an unused dependency over to use SharedTransformSystem
LineEdit and TextEdit never use their IClyde dependencies and it generates a warning so yeet
Removes a bunch of unused private IEntityManager vars Also removes an obsolete use of TransformComponent.GetWorldPositionRotation
There's nothing saying why this is this way and the blame looks like it was an oversight when replacing a bit where they set position and then rotation Please, oh Chesterton's Fence, spare me your wrath
Use #else sections to make sure they don't complain about being on the wrong side of a throw
TemporalOroboros
requested review from
metalgearsloth,
PJB3005 and
DrSmugleaf
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mass-purge of obsolete method calls.