Clothing HideLayerComponent breaks on clothing with multiple equipment slots #33965
Labels
A: Art
Area: Art with no implications for other areas.
D2: Medium
Difficulty: A good amount of codebase knowledge required.
P2: Raised
Priority: Item has a raised priority, indicating it might get increased maintainer attention.
T: Bugfix
Type: Bugs and/or bugfixes
T: Visual Change
Type: Deals with changes to art, sprites or other visuals in the game.
Description
Clothing with a HideLayerComponent will fail to properly hide the designated layers if the clothing being equipped has multiple potential equip slots.
I initially reported this here on RMC as their gas mask has both Mask and SuitStorage equip slots, so that they can be attached to a hazard vest. We tracked the issue down to Content.Shared/Clothing/EntitySystems/ClothingSystem.cs line 104. I don't know if this currently effects any items on WizDen, but it definitely impacts items on other forks and it would be helpful to sort it out here.
Reproduction
Screenshots
Additional context
It may be tempting to simply change this line to see if the clothing item's slots list contains the relevant slot for that layer. However, this would result in a snout layer being hidden when a mask is equipped on the SuitStorage slot, for instance.
The solution here will need to check that specifically the slot the item is equipped in applies to that layer.
The text was updated successfully, but these errors were encountered: