Set up CI, enforce gofmt #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
reviewed
Feb 4, 2024
rnestler
reviewed
Feb 4, 2024
Comment on lines
+29
to
+30
| - name: run gofmt | ||
| run: diff -u <(echo -n) <(gofmt -d ./) |
There was a problem hiding this comment.
Isn't it enough to just run gofmt with the -d flag?
There was a problem hiding this comment.
Nah, for some reason they seem to think that it's helpful to return exit code 0 even if there are changes...
https://stackoverflow.com/questions/42510140/check-format-for-continous-integration
There was a problem hiding this comment.
I mean I'd expect it to have a --check flag or similar and then return an error, but it doesn't seem to have that.
There was a problem hiding this comment.
I expected such a flag as well, but it probably breaks some kind of perceived unix philosophy - why implement a feature if you can do it with convoluted shell pipelines as well? 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See diff - let's hope it works :)