added 2 new rules and other changes in db, ingress and deployments #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YourTechBud
requested changes
Jan 26, 2021
There was a problem hiding this comment.
@shubham4443 lets get on a video call where you can demo me what you've done
| <Form.Item name='f2' rules={[{ required: true }, { validator: createValueAndTypeValidator(type, true) }]}> | ||
| <ObjectAutoComplete placeholder="Second operand" options={autoCompleteOptions} /> | ||
| </Form.Item> | ||
| <> |
| @@ -152,7 +152,7 @@ function GraphEditor({ rule, setRule, ruleName, ruleMetaData, isCachingEnabled } | |||
| } | |||
| return | |||
| } | |||
| if (selectedRuleObj.rule === "query" || selectedRuleObj.rule === "force" || selectedRuleObj.rule === "remove" || selectedRuleObj.rule === "encrypt" || selectedRuleObj.rule === "decrypt" || selectedRuleObj.rule === "hash") { | |||
| if (selectedRuleObj.rule === "query" || selectedRuleObj.rule === "force" || selectedRuleObj.rule === "remove" || selectedRuleObj.rule === "encrypt" || selectedRuleObj.rule === "decrypt" || selectedRuleObj.rule === "hash" || selectedRuleObj.rule === "graphql") { | |||
There was a problem hiding this comment.
I dont think we need a clause for the graphql rule
| @@ -33,7 +33,7 @@ const convertRuleToGraph = (rule, id, parentId) => { | |||
| graph.nodes.push({ id: `${id}.clauses.${len}`, label: "+ Add clause", group: "add_rule" }) | |||
| graph.edges.push({ from: id, to: `${id}.clauses.${len}` }) | |||
| } | |||
| if (rule.rule === "query" || rule.rule === "force" || rule.rule === "remove" || rule.rule === "encrypt" || rule.rule === "decrypt" || rule.rule === "hash") { | |||
| if (rule.rule === "query" || rule.rule === "force" || rule.rule === "remove" || rule.rule === "encrypt" || rule.rule === "decrypt" || rule.rule === "hash" || rule.rule === "graphql") { | |||
There was a problem hiding this comment.
no clause in graphql rule
sharadregoti
previously approved these changes
Jan 28, 2021
|
Following changes were made in this PR
|
sharadregoti
previously approved these changes
Jan 29, 2021
YourTechBud
previously approved these changes
Jan 29, 2021
shubham4443
dismissed stale reviews from YourTechBud and sharadregoti
via
1d482b2
|
Why there is no autocomplete when I load fields from a variable? |
|
2: 3: |
|
4: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.