Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventing settings #232

Open
wants to merge 6 commits into
base: v0.22.0-old
Choose a base branch
from

Conversation

shubham4443
Copy link
Contributor

  1. Disabling eventing
  2. Truncate event logs
  3. Changes in payload of eventing config
  4. Remove allow, deny and authenticated from eventing filtering rules

@sharadregoti
Copy link
Contributor

  1. Allow adding custom databases in disable settings of eventing
    image

@Saif-Ali-Kamal
Copy link
Contributor

  • disabling eventing are not visible at time of edit, maybe there is issue in initialValue
  • also test it by putting some in mirage data

@Saif-Ali-Kamal
Copy link
Contributor

Saif-Ali-Kamal commented Mar 4, 2021

  • Change in formItemLabel
    Enable eventing
    Select the database & table on which the eventing has to be enabled
  • If the you get empty values ("") for db or it's keys from backend show *
  • Add field validation
    if database name is * than disable add button
    don't allow empty field submissions
    don't allow to add another field if previous field is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants