Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI listtransactions command #29

Merged
merged 9 commits into from
Nov 18, 2024
Merged

CLI listtransactions command #29

merged 9 commits into from
Nov 18, 2024

Conversation

Ximik
Copy link
Contributor

@Ximik Ximik commented Nov 11, 2024

No description provided.

buffrr
buffrr requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@buffrr buffrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks alex i added a few comments

node/src/bin/space-cli.rs Outdated Show resolved Hide resolved
node/src/wallets.rs Show resolved Hide resolved
protocol/src/lib.rs Outdated Show resolved Hide resolved
@Ximik Ximik changed the title CLI listtransactions command and JSON response fixes CLI listtransactions command Nov 11, 2024
buffrr
buffrr approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@buffrr buffrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@buffrr buffrr merged commit 5198a46 into spacesprotocol:main Nov 18, 2024
1 check passed
@Ximik Ximik deleted the listtransactions branch December 1, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffrr buffrr buffrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ximik @buffrr