Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revoke state for bid_psbt_bad_signature events #37

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix revoke state for bid_psbt_bad_signature events #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions protocol/src/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ impl Validator {
) {
let input = tx.input.get(input_index as usize).expect("input");
let mut spaceout = stxo.previous_output;
let space_ref = spaceout.space.as_mut().unwrap();
let space_ref = spaceout.space.as_ref().unwrap();
// Handle bid spends
if space_ref.is_bid_spend(tx.version, input) {
// Bid spends must have an auctioned output
Expand Down Expand Up @@ -526,7 +526,7 @@ impl Validator {
None
};

space_ref.covenant = Covenant::Bid {
let new_covenant = Covenant::Bid {
signature: auctioned_output.bid_psbt.signature,
total_burned: total_burned + auctioned_output.bid_psbt.burn_amount,
burn_increment: auctioned_output.bid_psbt.burn_amount,
Expand All @@ -542,11 +542,16 @@ impl Validator {
txid: auctioned_output.bid_psbt.outpoint.txid,
spaceout: auctioned_spaceout,
};
fullspaceout.spaceout.space = Some(spaceout.space.unwrap());
let mut updated_space = spaceout.space.clone().unwrap();
updated_space.covenant = new_covenant;
fullspaceout.spaceout.space = Some(updated_space);

if !fullspaceout.verify_bid_sig() {
changeset.updates.push(UpdateOut {
output: fullspaceout,
output: FullSpaceOut {
txid: input.previous_output.txid,
spaceout,
},
kind: UpdateKind::Revoke(RevokeReason::BidPsbt(BidPsbtReason::BadSignature)),
});
return;
Expand Down
Loading