v0.0.5 updates #49
Merged
v0.0.5 updates #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was added as an additional safety check, but it should use the output index to actually determine if there's an existing space as it could cause a revoke during batch transfers (perhaps we should remove it all together)
If a user was outbid while their transaction is still in the mempool, the pending transaction gets stuck in the wallet which could result in building invalid chains of transactions on top. The solution is either to rescan the wallet to forget the tx or, for now, we just watch bids in memory and manually insert them to the chain so that bdk can purge the double spent tx. This is a temporary solution until bdk does this automatically or adds better tx invalidation APIs
This is to prevent accidental revokes and used as a last line of defense before a transaction is broadcasted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds many things for stability, fixes some bugs and makes error handling more robust.
--skip-tx-checkcheckpackagerpc command which is useful for the mempool. It can take a list of ordered transactions and simulate what they will do. It can be useful for mempool bids, opens ... etc and can be integrated perhaps for the explorer.