Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing error array dimension from TicaCubeFactory #87

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

hmlewis-astro
Copy link
Contributor

Addressing ticket ASB-22318. Created a test cube using 500 FFIs from TICA Sector 67, cam1-ccd1. Created cube has expected dimensions, see output from fitsinfo below. Cube created without error array is ~1/2 the size of a cube created with the error array (8.68 vs 17.35 GB).

Filename: /home/halewis/hlsp/tica/tica_cubes/s0067/tica-s0067-1-1-cube.fits
No.    Name      Ver    Type      Cards   Dimensions   Format
 0  PRIMARY       1 PrimaryHDU     198   ()      
 1                1 ImageHDU         9   (1, 500, 2136, 2078)   float32   
 2                1 BinTableHDU    598   500R x 198C   [D, J, J, J, J, D, J, J, 2A, D, D, D, D, D, D, D, D, D, D, D, D, J, J, J, J, J, J, J, D, J, D, D, D, D, D, D, D, D, 3A, J, J, 16A, D, D, D, D, 9A, 5A, D, 15A, 4A, 4A, D, D, D, D, D, D, D, D, 12A, 12A, D, D, D, D, J, J, J, J, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, D, J, J, J, 16A, 10A, 49A, 64A]

@jaymedina
Copy link
Collaborator

This is looking good! I added a commit to update the test_make_cube unit test for TicaCubeFactory, and I'm going to run some tests on my Jupyter NB, but apart from that, this PR is almost ready to go. Something within the scope of this PR is a documentation upgrade to reflect your changes: Would you mind going into the Astrocut docs and modifying this page in particular with a breakdown of the TICA cube file format now that it deviates from the SPOC cubes? TICA was due for it's own section anyway because some of the header keywords are analogous but not exactly the same.

Copy link
Collaborator

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some tests in a Jupyter notebook (see Jira ticket for step 2. in the Error Array Epic) and all looks fine. I've also rebased my CutoutFactory changes (#88) onto the changes in this branch, and the CI tests are passing again, so all is looking good.

In a previous comment, I'd asked to update the documentation, but my changes in #88 also need to be reflected in the documentation, so it's best to have the documentation update be its own PR so that it's more self-contained. I've made a Jira ticket for this task, it's step 3.5. I'm happy to take it on after I worked on some of my other tasks for this sprint.

@jaymedina jaymedina merged commit cc6589c into main Jul 26, 2023
1 of 6 checks passed
@jaymedina jaymedina deleted the rm-tica-error-ASB-22318 branch July 26, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants