Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VimbaPython dependency from environment.yml #257

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ivalaginja
Copy link
Collaborator

@ivalaginja ivalaginja commented Oct 24, 2024

Removing the VimbaPython dependency from the environment.yml file since we moved on to https://github.com/alliedvision/VmbPy for the AV cameras anyway. Also, the VimbaPython repo has now been archived, and we're getting installation errors.

Note how this does not resolve the issue #229 since I am not adding the VmbPy installation. I haven't had time to test how to install it from their repo (we had issues with this before), and in the meantime I asked whether they might distribute their package rather than having everybody download it manually (alliedvision/VmbPy#39).

@ivalaginja ivalaginja added the infrastructure Anything concerning CI, testing, linting or repo infrastructure. label Oct 24, 2024
@ivalaginja ivalaginja self-assigned this Oct 24, 2024
Copy link
Collaborator

@raphaelpclt raphaelpclt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@ivalaginja ivalaginja force-pushed the feature/remove_VimbaPython_dependency branch from 0d20fd1 to 53a52d3 Compare October 25, 2024 09:23
@ivalaginja ivalaginja merged commit 841cf55 into develop Oct 25, 2024
6 checks passed
@ivalaginja ivalaginja deleted the feature/remove_VimbaPython_dependency branch October 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything concerning CI, testing, linting or repo infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants