Skip to content

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Jun 16, 2025

Resolves HLA-1415

This PR documents the alignment configuration files for pipeline products, SVMs and MVMs.

  1. I've added documentation to the HAP-parameters page with a table showing the rules for the configuration files. I've attached a rendering of the RTD page for ease of review. The table is cut off in the screenshot, but one can slide over on the actual page.
  2. I noticed that in several cases, we specify a "any_4" file, but it is identical to the "any_2" file. In this case, i've removed the "any_4" file and updated the config_utils.py file to point to the "any_2" in the case of 2, 3, 4, or 5 exposures. This was already done for some of the detectors, so I'm doing it for all the relevant cases for consistency.
  3. As the MVM's either use "any_1" for 1 exposure or "any_2" for all other cases, I've removed the "any_4" and "any_6" parameter files as they are not used.

I've also added a helpful link from the SVM-processing section that touches on these filenames, to this documentation.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)

Regression test passing: Link

@s-goldman s-goldman requested review from mdlpstsci and a team as code owners June 16, 2025 20:55
@s-goldman s-goldman added Documentation code cleanup Code refactoring, cleanup of temporary code jirahub-ignore Avoid linking to Jira labels Jun 16, 2025
@s-goldman
Copy link
Collaborator Author

Screenshot 2025-06-16 at 4 33 31 PM

@mdlpstsci mdlpstsci added code cleanup Code refactoring, cleanup of temporary code and removed code cleanup Code refactoring, cleanup of temporary code labels Jun 17, 2025
Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments here:

  1. I do not see where the SVM *_index.json files were cleaned up.
  2. I do think the remaining astrodrizzle mapped filenames (e.g., filter_basic, etc.) should be described. I would make this a different ticket, as this ticket is already filled with lots of changes and bookkeeping.
  3. I do not see where the PyTests were updated. In any case, please make sure all the cases have really been tested as I am guessing the current set of PyTests may not cover all the "n#" cases, or the special pre- and post- UVIS cases. You may have to make-up some datasets to test all the cases (use a large dataset and remove individual images to test the n3, n2, or use a small dataset and duplicate the names of the files to process - just suggestions).

@s-goldman s-goldman dismissed mdlpstsci’s stale review June 18, 2025 16:04

Changes have been addressed.

Still to do: open new ticket for followup-work, additional tests of condition mapping for SVMs.

@s-goldman
Copy link
Collaborator Author

A reminder to check to see if this closes HLA-1508.

@s-goldman
Copy link
Collaborator Author

A ticket has been opened (HLA-1523) to add additional documentation for the non-alignment conditions.

@s-goldman
Copy link
Collaborator Author

@mdlpstsci I've done testing for, I think, all of the SVM conditions. I haven't done the same for the MVM as those take longer and I haven't actually change any of the MVM conditions, I've only removed files that never get used. Would you like me to test the MVM conditions, or are you happy with tests on the SVMs?

@mdlpstsci
Copy link
Collaborator

@s-goldman
It will take me a bit before I get back to reviewing this ticket as I have to reset my thinking! As for the MVMs...since you have not changed an MVM conditions, I am fine with the testing you have done thus far. I was just concerned about the SVMs, as there were a lot of "bookkeeping" changes.

@s-goldman s-goldman requested review from nden and mdlpstsci August 28, 2025 17:16
@s-goldman s-goldman requested a review from mdlpstsci September 8, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code refactoring, cleanup of temporary code Documentation jirahub-ignore Avoid linking to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants