-
Notifications
You must be signed in to change notification settings - Fork 40
HLA-1415: Remove unused alignment parameter files and update documentation #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HLA-1415: Remove unused alignment parameter files and update documentation #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comments here:
- I do not see where the SVM *_index.json files were cleaned up.
- I do think the remaining astrodrizzle mapped filenames (e.g., filter_basic, etc.) should be described. I would make this a different ticket, as this ticket is already filled with lots of changes and bookkeeping.
- I do not see where the PyTests were updated. In any case, please make sure all the cases have really been tested as I am guessing the current set of PyTests may not cover all the "n#" cases, or the special pre- and post- UVIS cases. You may have to make-up some datasets to test all the cases (use a large dataset and remove individual images to test the n3, n2, or use a small dataset and duplicate the names of the files to process - just suggestions).
Changes have been addressed.
Still to do: open new ticket for followup-work, additional tests of condition mapping for SVMs.
A reminder to check to see if this closes HLA-1508. |
A ticket has been opened (HLA-1523) to add additional documentation for the non-alignment conditions. |
@mdlpstsci I've done testing for, I think, all of the SVM conditions. I haven't done the same for the MVM as those take longer and I haven't actually change any of the MVM conditions, I've only removed files that never get used. Would you like me to test the MVM conditions, or are you happy with tests on the SVMs? |
@s-goldman |
Resolves HLA-1415
This PR documents the alignment configuration files for pipeline products, SVMs and MVMs.
I've also added a helpful link from the SVM-processing section that touches on these filenames, to this documentation.
Checklist for maintainers
CHANGELOG.rst
within the relevant release sectionRegression test passing: Link