Skip to content

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Sep 8, 2025

Resolves HLA-1542

This PR removes the deprecated function check_and_get_data from the align.py module. It also remove some deprecated tests that were used to verify the code. I have also removed a csv file and the conftest.py files as they are no longer used.

The check_and_get_data function was previously used for testing random datasets when vetting HAP products. It was used to download the relevant data if an ippsoot root (without any underscores) was given as an input to align.perform_align(); this functionality has been removed as it is no longer used, and can cause confusion as to whether a dataset has been overwritten.

The check_and_get_data function was still being used by one HAP regression test, test_apriori.py, but I have instead created a get_mast_data method in test_resources to retrieve the necessary data.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)

Regression test: Link

@s-goldman s-goldman added the code cleanup Code refactoring, cleanup of temporary code label Sep 8, 2025
@s-goldman s-goldman marked this pull request as ready for review September 15, 2025 14:51
@s-goldman s-goldman requested a review from a team as a code owner September 15, 2025 14:51
@s-goldman s-goldman requested review from nden and mcara September 18, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code refactoring, cleanup of temporary code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant