Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild all #60

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Rebuild all #60

merged 5 commits into from
Aug 19, 2024

Conversation

jaytmiller
Copy link
Collaborator

  • Overall goal is all missions should build and test at least floating. Frozen requirements included but BS like "yanked" packages are an issue.
  • Adds some missing fix-permissions calls needed to build jwebbinar.
  • Tweaks unit tests (generally tossing tests w/o support) so all missions build and test.
  • Improves update-all script to support --build and --test (where --test implies --build but both cannot be specified. Otherwise it is just a Dockerfile update. But policing all 3 missions is really needed.)

msanchezst
msanchezst approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@msanchezst msanchezst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@jaytmiller jaytmiller merged commit 2b218a8 into spacetelescope:main Aug 19, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanchezst msanchezst msanchezst approved these changes

@cganley1 cganley1 Awaiting requested review from cganley1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytmiller @msanchezst